Let’s gooooooooo
You must log in or register to comment.
yeeeeaaaaaaaa - see what you can do about hiding viewed content ^*
Sounds like a cool feature. I’m honestly down for doing a good chunk of
lemmy-uidev work as I’m kind of getting rusty in React with my new job being strictly backend these days.I might look into it myself, definitely curious but i’m always cautious with open source projects when committing a decently sized PR - yea that’s a great way to keep the knives sharp
If the size of the PR is a concern, maybe the maintainers will allow a staged approach. Create an Issue describing the feature and indicate step by step how you would implement. Then break the work into multiple pull requests.
If necessary, you could introduce a toggle that’s switched off by default until the feature is fully implemented.
ooooOO this is an interesting approach
Not a bad idea! The attack vector issue they mention in the PR comments is valid, though. Not displaying those errors gives an attacker no confirmation that a user whose account they’re trying to attack exists, if they’re trying known used passwords. But good on you doing what you can to contribute to the project!
There should be an error, but it shouldn’t say whether it was the email or password that was wrong.
