Description
Right now if you try to login and you provide an unknown username/email or a wrong password, you will get no toast message. This PR adds toast messages for those scenarios and uses the ...
Sounds like a cool feature. I’m honestly down for doing a good chunk of lemmy-ui dev work as I’m kind of getting rusty in React with my new job being strictly backend these days.
I might look into it myself, definitely curious but i’m always cautious with open source projects when committing a decently sized PR - yea that’s a great way to keep the knives sharp
If the size of the PR is a concern, maybe the maintainers will allow a staged approach. Create an Issue describing the feature and indicate step by step how you would implement. Then break the work into multiple pull requests.
If necessary, you could introduce a toggle that’s switched off by default until the feature is fully implemented.
Sounds like a cool feature. I’m honestly down for doing a good chunk of
lemmy-uidev work as I’m kind of getting rusty in React with my new job being strictly backend these days.I might look into it myself, definitely curious but i’m always cautious with open source projects when committing a decently sized PR - yea that’s a great way to keep the knives sharp
If the size of the PR is a concern, maybe the maintainers will allow a staged approach. Create an Issue describing the feature and indicate step by step how you would implement. Then break the work into multiple pull requests.
If necessary, you could introduce a toggle that’s switched off by default until the feature is fully implemented.
ooooOO this is an interesting approach