- cross-posted to:
- lemmyconnect@lemmy.ca
- cross-posted to:
- lemmyconnect@lemmy.ca
The whole code base uses naive date time and TIMESTAMP WITHOUT TIME ZONE.
Now there’s conversion issues appearing in federation where timezones are not handled correctly.
Using NaiveDateTime is … naive? So this PR removes all instances of naive time and adds defined timezones to everything (usually Utc).
Now, no conversions are needed anymore.
The database migration is extensive but it is free (no rewrite needed) since PG 12.
You must log in or register to comment.
After this, they will. We don’t manipulate the columns coming back from postgres, so UTC timestamp without timezone doesn’t include timestamp info for the 8601 format.
Originally posted by dessalines in #3496
This also needs changes to activitypub-federation: https://github.com/LemmyNet/activitypub-federation-rust/pull/62
There is again now a future post on lemmy.world probably due to this issue:
I’m def down for adding this, especially since it keeps everything in the UTC timezone.
It will be a breaking change so it’ll have to come with
v0.19, because clients will now receive all the timestamp columns with a timezone, rather than a UTC one they have to hack on aZstring to.Originally posted by dessalines in #3496