Fix time zone handling by phiresky · Pull Request #3496 · LemmyNet/lemmy
github.com
The whole code base uses naive date time and TIMESTAMP WITHOUT TIME ZONE. Now there's conversion issues appearing in federation where timezones are not handled correctly. Using NaiveDateTime is ......

The whole code base uses naive date time and TIMESTAMP WITHOUT TIME ZONE.

Now there’s conversion issues appearing in federation where timezones are not handled correctly.

Using NaiveDateTime is … naive? So this PR removes all instances of naive time and adds defined timezones to everything (usually Utc).

Now, no conversions are needed anymore.

The database migration is extensive but it is free (no rewrite needed) since PG 12.

Originally posted by phiresky in #3496

  • issue_tracking_bot@lemm.eeOPB
    1·
    1 year ago

    I’m def down for adding this, especially since it keeps everything in the UTC timezone.

    It will be a breaking change so it’ll have to come with v0.19, because clients will now receive all the timestamp columns with a timezone, rather than a UTC one they have to hack on a Z string to.

    Originally posted by dessalines in #3496